Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

add NXP PN532 NFC #2758

Merged
merged 2 commits into from
Sep 22, 2020
Merged

add NXP PN532 NFC #2758

merged 2 commits into from
Sep 22, 2020

Conversation

jneiva08
Copy link
Contributor

Have created library RF_NFC, if it should be in other place let me know (#2725)

Datasheet: https://www.nxp.com/docs/en/nxp/data-sheets/PN532_C1.pdf

Footprint PR: KiCad/kicad-footprints#2303

Symbol screenshot:
symbol

Pin table:
pins_p1

pins_p2


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • Provide a screenshot of the symbol(s) from the symbol editor with the pin types visible
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing additional info like the screenshot of the symbol editor pin table (or for high pin counts converted to csv) sorted in the same way as the pin table in the datasheet and a direct link to the datasheet page that contains the pin table.

@myfreescalewebpage myfreescalewebpage added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels May 28, 2020
@myfreescalewebpage myfreescalewebpage self-assigned this Aug 23, 2020
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Aug 23, 2020
@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Aug 23, 2020

Hi @jneiva08 , thanks for contributing,

A few comments I have during my review:

  • I0 above I1 is better
  • Name of pin 34 "SIC_CLK/P34" to have the main function near to the border of the symbol

Cheers,
Joel

@myfreescalewebpage myfreescalewebpage added the Pending footprint Pending footprint acceptance before merging label Aug 23, 2020
Switch text order in P34
@jneiva08
Copy link
Contributor Author

@myfreescalewebpage, have made the changes requested

image

@myfreescalewebpage
Copy link
Collaborator

Thanks. Just need to wait the footprint now.

@myfreescalewebpage myfreescalewebpage removed the Pending footprint Pending footprint acceptance before merging label Sep 22, 2020
@myfreescalewebpage
Copy link
Collaborator

Closing/opening to refresh the Travis test.

@myfreescalewebpage myfreescalewebpage merged commit e855bb4 into KiCad:master Sep 22, 2020
@jneiva08
Copy link
Contributor Author

thanks for your time

@jneiva08 jneiva08 deleted the PN532 branch September 22, 2020 22:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants