Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Added symbol for the BAV756S diode #668

Merged
merged 7 commits into from
Jun 29, 2018
Merged

Conversation

Duckle29
Copy link
Contributor

@Duckle29 Duckle29 commented Jun 14, 2018

Added a symbol for the BAV756S, which is a chip with 4 diodes, 2 common Anode, 2 common cathode


datasheet

  • Ensure that the associated footprints match the official footprint library
  • Check the output of the Travis automated check scripts - fix any errors as required

@Misca1234
Copy link
Collaborator

It is desirable that you provide in the text both the data sheet link and a screen shot of the symbol showing the pin types etc.

something like this, then it is much easier and faster to give feedback

bild

bild

bild

bild

@Misca1234
Copy link
Collaborator

Misca1234 commented Jun 16, 2018

If so, then you can get the following feedback back rather quickly

Move the "Package_TO_SOT_SMD:SOT-363_SC-70-6" to just beneath the symbol, it is placed to far away

Change the description
"Quad diode package with one pair CA and one pair CC"
into
"Quad diode package with one pair CA and one pair CC, SOT323/SC-70"

Change the foot print filter to
SOT?363?SC?70?6*

@Duckle29
Copy link
Contributor Author

Thank you, yes that makes a lot of sense :)

@Duckle29
Copy link
Contributor Author

image
image
image
image

There we go :)

@evanshultz
Copy link
Collaborator

evanshultz commented Jun 20, 2018

The diodes should be "open" (unfilled) with a line in the middle like IEC shows and other diodes in our library.

I often find these dual diodes don't go on circuit right next to each other. What about making this a dual-unit symbol and copying the existing CA/CC diode symbol?

Edit: The description should have 363 and not 323.

Also, I would say the footprint filter could be SOT?323* since that will give the greatest flexibility if those footprints are ever split for some reason and it retains only the footprint name used by Nexperia.

@Duckle29
Copy link
Contributor Author

image
image
image
image

There we go. Made the symbol into a 2 unit symbol. and changed the filter back to the more generic filter.

I decided to center the diodes based on their pin positions, I don't know if I'd prefer the diode with the 2 horizontal pins on Y0, but I'll leave that up to you :)

@Duckle29
Copy link
Contributor Author

image
image

@evanshultz evanshultz self-assigned this Jun 27, 2018
@evanshultz
Copy link
Collaborator

This symbol type, like the existing generic diodes, is preferred.

  • There should be a line through the middle of the diode symbols.
  • Change description to High-speed switching diodes, dual common anode/common cathode, SOT-363.
  • Pin name offset to 1mil.
  • Remove underscore in pin names.

@evanshultz
Copy link
Collaborator

  • What about pins names of A1, K2, CA, K3, A4, and CK. That would change pin names for pins 3 and 6.
  • What about this symbol (removing overlapping lines, use common graphical elements where possible, all pin lengths to 100mil, and add junction dot):
# BAV756S
#
DEF BAV756S D 0 1 Y N 2 L N
F0 "D" 0 100 50 H V C CNN
F1 "BAV756S" 0 200 50 H V C CNN
F2 "Package_TO_SOT_SMD:SOT-363_SC-70-6" 0 -400 50 H I C CNN
F3 "" 0 -400 50 H I C CNN
$FPLIST
 SOT?363*
$ENDFPLIST
DRAW
C 0 0 10 0 1 0 F
P 2 0 1 0 -200 0 200 0 N
P 2 0 1 0 0 0 0 -100 N
P 3 1 1 8 -50 -50 -50 50 -50 50 N
P 3 1 1 8 50 -50 50 50 50 50 N
P 6 1 1 8 -150 50 -50 0 -150 -50 -150 50 -150 50 -150 50 N
P 6 1 1 8 150 -50 50 0 150 50 150 -50 150 -50 150 -50 N
X A1 1 -300 0 100 R 50 50 1 1 P
X A4 5 300 0 100 L 50 50 1 1 P
X CK 6 0 -200 100 U 50 50 1 1 P
P 3 2 1 8 -150 50 -150 -50 -150 -50 N
P 3 2 1 8 150 50 150 -50 150 -50 N
P 6 2 1 8 -50 -50 -150 0 -50 50 -50 -50 -50 -50 -50 -50 N
P 6 2 1 8 50 50 150 0 50 -50 50 50 50 50 50 50 N
X K2 2 -300 0 100 R 50 50 2 1 P
X CA 3 0 -200 100 U 50 50 2 1 P
X K3 4 300 0 100 L 50 50 2 1 P
ENDDRAW
ENDDEF

image

@evanshultz
Copy link
Collaborator

@Duckle29
Visually this is fine. Probably many of our diodes can be updated later. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants