Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exiftool replacement #624

Merged
merged 29 commits into from
May 11, 2024
Merged

Exiftool replacement #624

merged 29 commits into from
May 11, 2024

Conversation

Kicer86
Copy link
Owner

@Kicer86 Kicer86 commented Apr 6, 2024

No description provided.

@Kicer86 Kicer86 marked this pull request as draft April 6, 2024 19:41
@Kicer86
Copy link
Owner Author

Kicer86 commented Apr 10, 2024

Windows build blocked with microsoft/vcpkg#38054

@Kicer86
Copy link
Owner Author

Kicer86 commented Apr 16, 2024

Fixes #576

@Kicer86
Copy link
Owner Author

Kicer86 commented Apr 18, 2024

Depends on #580 (earlier versions of exiv2 do not provide video tags)

@Kicer86 Kicer86 marked this pull request as ready for review April 18, 2024 19:26
@Kicer86 Kicer86 force-pushed the exiftool_replacement branch 2 times, most recently from 72ba887 to ade967b Compare May 10, 2024 19:17
Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 96.10390% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 83.48%. Comparing base (664db9a) to head (7184492).

Files Patch % Lines
src/core/implementation/aexif_reader.cpp 50.00% 2 Missing ⚠️
...rc/core/implementation/video_media_information.cpp 97.95% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #624      +/-   ##
==========================================
- Coverage   83.73%   83.48%   -0.25%     
==========================================
  Files         183      189       +6     
  Lines        7855     7951      +96     
==========================================
+ Hits         6577     6638      +61     
- Misses       1278     1313      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kicer86 Kicer86 merged commit a1ad7d9 into master May 11, 2024
9 of 10 checks passed
@Kicer86 Kicer86 deleted the exiftool_replacement branch May 11, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant