refactor(server/vehicle): create interface for CreateVehicleData

KickRP · Sep 23, 2024 · b8c125a · b8c125a
1 parent d2b6b24
commit b8c125a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 17 deletions.
diff --git a/lib/server/vehicle.ts b/lib/server/vehicle.ts
@@ -1,5 +1,5 @@
 import type { OxVehicle as _OxVehicle } from 'server/vehicle/class';
-import type { VehicleProperties } from '@overextended/ox_lib';
+import type { CreateVehicleData } from 'server/vehicle';
 
 class VehicleInterface {
   constructor(
@@ -77,13 +77,7 @@ export function GetVehicleFromVin(vin: string) {
 }
 
 export async function CreateVehicle(
-  data: {
-    model: string;
-    owner?: number;
-    group?: string;
-    stored?: number;
-    properties?: VehicleProperties;
-  },
+  data: CreateVehicleData,
   coords?: number | number[] | { x: number; y: number; z: number },
   heading?: number
 ) {

diff --git a/server/vehicle/index.ts b/server/vehicle/index.ts
@@ -12,16 +12,16 @@ if (DEBUG) import('./parser');
 
 type Vec3 = number[] | { x: number; y: number; z: number } | { buffer: any };
 
+export interface CreateVehicleData {
+  model: string;
+  owner?: number;
+  group?: string;
+  stored?: string;
+  properties?: VehicleProperties;
+}
+
 export async function CreateVehicle(
-  data:
-    | string
-    | (Partial<VehicleRow> & {
-        model: string;
-        owner?: number;
-        group?: string;
-        stored?: string;
-        properties?: VehicleProperties;
-      }),
+  data: string | CreateVehicleData & Partial<VehicleRow>,
   coords?: Vec3,
   heading?: number,
   invokingScript = GetInvokingResource()