Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix up build for netcore 3.1 #100

Merged
merged 4 commits into from
Dec 18, 2019
Merged

chore: Fix up build for netcore 3.1 #100

merged 4 commits into from
Dec 18, 2019

Conversation

Kieranties
Copy link
Owner

@Kieranties Kieranties commented Dec 17, 2019 •
edited
Loading

Description

Updates to support building under netcore sdk 3.1.100

  • Update build to run dotnet-install LTS install before dotnet is called
  • Update CentralPackageVersion to 2.0.52
  • Fixed issue in build script with incorrect configuration environment being used
  • Nuget packages now use PackageIcon

Aiming to provide a fix to enable #99 to build

Change Type

  • Documentation: Changes to docs are included
  • Infrastructure: Changes to build scripts/non-deliverables
  • Bug Fix: Fixes an issue in implementation
  • New Feature: Adds new functionality in a non-breaking manner
  • Breaking Change: Implements a fix or feature in a breaking manner

Quality

  • Unit tests have been added/updated
  • Local builds/testing are successful
  • Code coverage has not decreased
  • Code comments have been provided (where appropriate)
  • Core styles have been followed
  • Documentation has been added/updated

@Kieranties Kieranties added the 🏗️ infrastructure Issues affecting build, deployment, testing, and other aspects outside of code label Dec 17, 2019
@Kieranties Kieranties changed the title chore: Fix up build for netcore 3.1 chore: Fix up build for netcore 3.0 Dec 17, 2019
@Kieranties Kieranties mentioned this pull request Dec 17, 2019
Merged
6 tasks
@Kieranties Kieranties merged commit 2fc7e0b into master Dec 18, 2019
@Kieranties Kieranties deleted the feature/netcoresdk branch December 18, 2019 16:55
@Kieranties Kieranties changed the title chore: Fix up build for netcore 3.0 chore: Fix up build for netcore 3.1 Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏗️ infrastructure Issues affecting build, deployment, testing, and other aspects outside of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Kieranties