Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Align documentation, clarify label property #113

Merged
merged 1 commit into from
May 25, 2020

Conversation

JonasBang
Copy link
Contributor

Description

Align wording and structure in documentation, clarify adding of height to pre-release labels, fix incorrect "label" property.

Change Type

  • Documentation: Changes to docs are included
  • Infrastructure: Changes to build scripts/non-deliverables
  • Bug Fix: Fixes an issue in implementation
  • New Feature: Adds new functionality in a non-breaking manner
  • Breaking Change: Implements a fix or feature in a breaking manner
  • Other -

Quality Checks

  • Unit tests have been added/updated
  • Local builds/testing are successful
  • Code coverage has not decreased
  • Code comments have been provided (where appropriate)
  • Core styles have been followed
  • Documentation has been added/updated

Align wording and structure in documentation, clarify adding of height to pre-release labels, fix incorrect "label" property.
@JonasBang JonasBang requested a review from Kieranties as a code owner May 25, 2020 08:54
Copy link
Owner

@Kieranties Kieranties left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it when my native language is corrected by a non-native speaker!
I'm looking into adjusting the build pipeline so I can more easily publish doc changes.
These will get published once I've fixed it up.

@Kieranties Kieranties merged commit eb699e3 into Kieranties:master May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants