Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support fallback environment source branch #146

Merged
merged 8 commits into from
May 15, 2022

Conversation

Kieranties
Copy link
Owner

@Kieranties Kieranties commented May 8, 2022

Description

Exposes simpleversion.sourcebranch - enabling a fallback environment variable for any build system to use.

The primary concern is to alleviate TeamCity issues as identified in #141 and #142

By setting the environment variable any build system can be explicit about the canonical branch name to be used in version calculation

Fixes #141
Replaces #142

Change Type

  • Documentation: Changes to docs are included
  • Infrastructure: Changes to build scripts/non-deliverables
  • Bug Fix: Fixes an issue in implementation
  • New Feature: Adds new functionality in a non-breaking manner
  • Breaking Change: Implements a fix or feature in a breaking manner
  • Other -

Quality Checks

  • Unit tests have been added/updated
  • Acceptance tests have been added/updated
  • Local builds/testing are successful
  • Code coverage has not decreased
  • Code comments have been provided (where appropriate)
  • Core styles have been followed
  • Documentation has been added/updated

@Kieranties Kieranties added ✨ feature New feature or request 📄 docs Update to or creation of documentation labels May 8, 2022
@Kieranties Kieranties mentioned this pull request May 8, 2022
13 tasks
@ghost
Copy link

ghost commented May 10, 2022

Looking great, thanks for this.

@Kieranties Kieranties force-pushed the feature/fallback-environment branch from ccc072e to 60c8b8c Compare May 15, 2022 07:54
@Kieranties Kieranties enabled auto-merge (squash) May 15, 2022 07:57
@Kieranties Kieranties disabled auto-merge May 15, 2022 07:57
@Kieranties Kieranties merged commit 4fc670e into master May 15, 2022
@Kieranties Kieranties deleted the feature/fallback-environment branch May 15, 2022 07:58
@ghost
Copy link

ghost commented May 18, 2022

@Kieranties can confirm the fallback environment works. One little note - i've set the simpleversion.sourcebranch to teamcity.build.branch instead of teamcity.build.vcs.branch. because that allows for better templating and generic usage. Works both ways - the difference is just if the refs/ is added or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 docs Update to or creation of documentation ✨ feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requesting new Environment - Teamcity
1 participant