Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Resolve msbuild warnings #89

Merged
merged 4 commits into from
Jul 1, 2019
Merged

chore: Resolve msbuild warnings #89

merged 4 commits into from
Jul 1, 2019

Conversation

Kieranties
Copy link
Owner

Description

Addresses recent msbuild issues that had temporarily been disabled.

Fixes #84

Change Type

  • Documentation: Changes to docs are included
  • Infrastructure: Changes to build scripts/non-deliverables
  • Bug Fix: Fixes an issue in implementation
  • New Feature: Adds new functionality in a non-breaking manner
  • Breaking Change: Implements a fix or feature in a breaking manner

Quality

  • Unit tests have been added/updated
  • Local builds/testing are successful
  • Code coverage has not decreased
  • Code comments have been provided (where appropriate)
  • Core styles have been followed
  • Documentation has been added/updated

@Kieranties Kieranties added this to the 0.2.0 milestone Jul 1, 2019
@Kieranties Kieranties added the 🏗️ infrastructure Issues affecting build, deployment, testing, and other aspects outside of code label Jul 1, 2019
@Kieranties Kieranties merged commit f3a1f4c into master Jul 1, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/msbuildfixes branch July 1, 2019 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏗️ infrastructure Issues affecting build, deployment, testing, and other aspects outside of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address msbuild warnings
1 participant