Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 2 commits
- 5 files changed
- 3 contributors
Commits on Jan 2, 2025
-
fix: googletag.display errors when ad slot not in DOM (#142)
## Description This PR fixes an issue where GPT complains if googletag.displaySlots() is called for a defined ad slot that is not yet in the DOM, i.e. ``` GPT] Error in googletag.display: could not find div with id "my-ad-id" in DOM for slot: /my/ad/unit/path ``` - The fix is to defer the calling of `Advertising.displaySlots()`. So instead calling this method in `Advertising.setupGpt()`, we are now calling it at the end of `Advertising.active()`. - I've also refactored displaySlots() to accept an id and to only call `window.googletag.display(id)` for this single `id`, instead of iterating through all the slots - `Advertising.active()` gets called from the `AdvertisingSlot` component, so now Advertising.displaySlots() will not fire for defined ad slots that are not yet in the DOM. - The solution was based on a suggestion from @Trav84, as outlined in: https://github.com/orgs/KijijiCA/discussions/141 --------- Co-authored-by: Stephen Gill <stephen.gill@adevinta.com>
-
chore(release): 4.2.15 [skip ci]
## [4.2.15](v4.2.14...v4.2.15) (2025-01-02) ### Bug Fixes * googletag.display errors when ad slot not in DOM ([#142](#142)) ([3e9615b](3e9615b))
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v4.2.14...v4.2.15