Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome to electron #6

Closed
wants to merge 4 commits into from
Closed

Conversation

yavorsky
Copy link
Contributor

Add chromiumToElectron method with reversed logic.
For performance and other purposes also added it to build.js for chrome-versions.js and full-chrome-versions.js builds.

@Kilian
Copy link
Owner

Kilian commented Mar 17, 2017

Nice extension, code looks fine :) Any particular use for this in mind?

Could you update the README.md with the new functions and lists? The full chrome versions returns an array instead of a string so that would be important to communicate clearly.

@yavorsky
Copy link
Contributor Author

@Kilian Ah, yes!

@Kilian
Copy link
Owner

Kilian commented Mar 24, 2017

Also needs the description for importing the individual version files. I don't mind doing this but don't know when I'll get around to it. If you beat me to it that would be great ;)

Copy link
Owner

@Kilian Kilian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use "chromium" instead of "chrome" for consistency, in the property names and filenames.

Please make sure that the new properties and files are added to the readme (with chromium in their names)

@Kilian
Copy link
Owner

Kilian commented Mar 26, 2017

I made the above changes in this branch: https://github.com/Kilian/electron-to-chromium/tree/yavorsky-chrome-to-electron

@yavorsky did I miss anything? if not, I'll merge that branch.

@yavorsky
Copy link
Contributor Author

@Kilian Can you please open PR yavorsky-chrome-to-electron to master to compare changes, reviews, etc? 🙂

@Kilian Kilian mentioned this pull request Mar 27, 2017
@Kilian
Copy link
Owner

Kilian commented Mar 27, 2017

Closing this to continue in #8.

@Kilian Kilian closed this Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants