-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chrome to electron #6
Conversation
Nice extension, code looks fine :) Any particular use for this in mind? Could you update the README.md with the new functions and lists? The full chrome versions returns an array instead of a string so that would be important to communicate clearly. |
@Kilian Ah, yes! |
Also needs the description for importing the individual version files. I don't mind doing this but don't know when I'll get around to it. If you beat me to it that would be great ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use "chromium" instead of "chrome" for consistency, in the property names and filenames.
Please make sure that the new properties and files are added to the readme (with chromium in their names)
I made the above changes in this branch: https://github.com/Kilian/electron-to-chromium/tree/yavorsky-chrome-to-electron @yavorsky did I miss anything? if not, I'll merge that branch. |
@Kilian Can you please open PR |
Closing this to continue in #8. |
Add chromiumToElectron method with reversed logic.
For performance and other purposes also added it to build.js for
chrome-versions.js
andfull-chrome-versions.js
builds.