Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the Message buf should be larger than 65536 #119

Closed
ColdwindY opened this issue Dec 7, 2021 · 3 comments
Closed

the Message buf should be larger than 65536 #119

ColdwindY opened this issue Dec 7, 2021 · 3 comments
Labels

Comments

@ColdwindY
Copy link

ColdwindY commented Dec 7, 2021

the Message buf should be larger than 65536,otherwise if -s 2000 then System.ArgumentException.
The max ICMP pkg is 65536. So just set
public byte[] Message = new byte[80000];
at line 39,ICMP.cs

@ColdwindY ColdwindY changed the title the Message buf should be larger tthan 65536 the Message buf should be larger than 65536 Dec 7, 2021
@Killeroo
Copy link
Owner

Killeroo commented Dec 9, 2021

Thanks for pointing this out. Yeah this seems to be a bug with the way that we are updating the ICMP message field, will submit a fix soon.

@Killeroo Killeroo added the Bug label Jun 27, 2023
@Killeroo Killeroo moved this to Todo in PowerPing v1.4.0 May 27, 2024
@Killeroo Killeroo moved this to Bugs in PowerPing v2.0.0 May 27, 2024
Killeroo added a commit that referenced this issue Jun 2, 2024
…bytes (#119 & #137)

Fixed receive buffer not scaling with size of packet being sent
@Killeroo
Copy link
Owner

Killeroo commented Jun 5, 2024

This should be fixed in the lasted release, you can download it here.

@Killeroo
Copy link
Owner

RecieveBuffer is now set to max ICMP size, closing this for now 👍

@github-project-automation github-project-automation bot moved this from Bugs to Done in PowerPing v2.0.0 Jun 11, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in PowerPing v1.4.0 Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Status: Done
Development

No branches or pull requests

2 participants