-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Allow toggling between continue and our existing provider again. #3645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
EamonNerbonne
commented
Nov 10, 2025
- FIM api endpoint for codestral #2912
|
|
Did you test building a vsix and loading it? |
Yes. No problems. But it's not surprising that's not revealing new problems, since prior crashes were due to the lru cache using sqlite, and we already use that cache now in the classic autocomplete, so this does nothing new in terms of loading; main already loads that code anyhow. |
|
Sure, but afaik we didnt verify sqlite wasnt used elsewhere? |
we dont. (and I don't observe crashes) |
| if (!(await checkKilocodeBalance(profile.kilocodeToken, profile.kilocodeOrganizationId))) continue | ||
| } | ||
|
|
||
| this.profile = profile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure? the code around here seems to sometimes use this and sometimes not; it also sometimes uses this.apihandler and sometimes this.profile.apiHandler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not entirely, but it seems to work? Don't really care as much now that I'm confident this is just a PoC and not a keeper...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked, and this is the only setter, and it is read, so possible the whole field can be avoided somehow, but we won't bother figuring it out. Looks like it's necessary.