Skip to content

Conversation

@EamonNerbonne
Copy link
Contributor

@changeset-bot
Copy link

changeset-bot bot commented Nov 10, 2025

⚠️ No Changeset found

Latest commit: 09bea12

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@markijbema
Copy link
Contributor

Did you test building a vsix and loading it?

@EamonNerbonne
Copy link
Contributor Author

Did you test building a vsix and loading it?

Yes. No problems. But it's not surprising that's not revealing new problems, since prior crashes were due to the lru cache using sqlite, and we already use that cache now in the classic autocomplete, so this does nothing new in terms of loading; main already loads that code anyhow.

@markijbema
Copy link
Contributor

Sure, but afaik we didnt verify sqlite wasnt used elsewhere?

@EamonNerbonne
Copy link
Contributor Author

Sure, but afaik we didnt verify sqlite wasnt used elsewhere?

we dont. (and I don't observe crashes)

if (!(await checkKilocodeBalance(profile.kilocodeToken, profile.kilocodeOrganizationId))) continue
}

this.profile = profile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure? the code around here seems to sometimes use this and sometimes not; it also sometimes uses this.apihandler and sometimes this.profile.apiHandler

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not entirely, but it seems to work? Don't really care as much now that I'm confident this is just a PoC and not a keeper...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked, and this is the only setter, and it is read, so possible the whole field can be avoided somehow, but we won't bother figuring it out. Looks like it's necessary.

@EamonNerbonne EamonNerbonne merged commit b067a14 into main Nov 11, 2025
12 checks passed
@EamonNerbonne EamonNerbonne deleted the eamon/FimTweaks2 branch November 11, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants