-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Include changes from Roo Code v3.32.0 #3895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Chris Estreich <cestreich@gmail.com>
…ellation" (#9032)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Matt Rubens <mrubens@users.noreply.github.com>
* fix: eliminate UI flicker during task cancellation - Modify ClineProvider.createTaskWithHistoryItem() to detect when rehydrating current task - Implement in-place task replacement to avoid empty stack state that causes UI flicker - Add comprehensive unit tests for flicker-free cancel behavior - Maintain backward compatibility and proper event listener cleanup Fixes the jarring navigation to home view when cancelling tasks * fix: ensure proper garbage collection of old task during flicker-free rehydration - Call abortTask(true) on old task before replacement to stop processes and mark as abandoned - This ensures proper cleanup and prevents memory leaks during task cancellation - Add test verification for abortTask cleanup
…#9030) - Add PathTooltip component that wraps StandardTooltip with proper styling - Use maxWidth='min(300px,100vw)' via inline style to override defaults - Apply '[text-wrap:wrap]' class to override text-balance behavior - Add formatPathTooltip helper for consistent path content formatting - Update CodeAccordian, ChatRow, and BatchFilePermission to use PathTooltip - Centralizes tooltip behavior and reduces duplication Supersedes PR #8797.
* fix: keep pinned models fixed at top of scrollable list - Separated pinned and unpinned configs into different containers - Pinned configs now stay fixed at the top - Only unpinned configs are scrollable - Added tests to verify the fixed behavior Fixes #8812 * fix: resolve sticky header visual artifact in ApiConfigSelector - Changed sticky header background from bg-vscode-editorWidget-background to bg-vscode-dropdown-background to match popover container - Moved separator logic into sticky container as conditional bottom border to prevent scroll artifacts - Updated tests to match new separator structure - All 21 tests passing --------- Co-authored-by: Roo Code <roomote@roocode.com> Co-authored-by: daniel-lxs <ricciodaniel98@gmail.com>
…in Dev Containers (#8811)
Aligns claude-opus-4-1-20250805 max token limit with claude-opus-4-20250514, both models now supporting 32K output tokens (overridable to 8K when enableReasoningEffort is false). Fixes #9045 Co-authored-by: Roo Code <roomote@roocode.com>
Co-authored-by: Roo Code <roomote@roocode.com>
…(#9060) Co-authored-by: Roo Code <roomote@roocode.com>
Co-authored-by: Roo Code <roomote@roocode.com>
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> Co-authored-by: Roo Code <roomote@roocode.com>
chore: add changeset for v3.30.2
* changeset version bump * Revise CHANGELOG for version 3.30.2 Updated changelog for version 3.30.2 with new features and fixes. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Matt Rubens <mrubens@users.noreply.github.com>
Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com> Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> Co-authored-by: Roo Code <roomote@roocode.com>
Co-authored-by: Roo Code <roomote@roocode.com> Co-authored-by: Daniel <57051444+daniel-lxs@users.noreply.github.com>
Co-authored-by: daniel-lxs <ricciodaniel98@gmail.com>
Co-authored-by: Roo Code <roomote@roocode.com> Co-authored-by: daniel-lxs <ricciodaniel98@gmail.com>
… disabled (#8216) Co-authored-by: Roo Code <roomote@roocode.com> Co-authored-by: daniel-lxs <ricciodaniel98@gmail.com>
Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com> Co-authored-by: Seth Miller <sethmillerp@gmail.com> Co-authored-by: heyseth <sethmillerp@gmail.com> Co-authored-by: Roo Code <roomote@roocode.com>
chrarnoldus
reviewed
Nov 26, 2025
This reapplies the changes from PR #3104 that were reverted during the Roo v3.32.0 merge. The fix ensures that newlines within quoted strings (e.g., multi-line git commit messages) are preserved and not treated as command separators during auto-approval validation. Changes: - Add src/shared/quote-protection.ts with protectNewlinesInQuotes function - Update src/shared/parse-command.ts to use quote protection before splitting - Add comprehensive tests for quote protection and parse-command
# Conflicts: # src/core/assistant-message/presentAssistantMessage.ts # src/core/tools/codebaseSearchTool.ts
…mit-auto-approve Reapply multi-line git commit message support in auto-approve (attempt 2)
chrarnoldus
approved these changes
Nov 26, 2025
This was
linked to
issues
Nov 26, 2025
This was referenced Nov 27, 2025
Merged
markijbema
added a commit
that referenced
this pull request
Nov 29, 2025
…te sharing When editing profile B while profile A is active, the handleSubmit function was sending upsertApiConfiguration to BOTH profiles: - Line 563: correctly saves to editingApiConfigName (profile B) - Line 592: incorrectly saves to currentApiConfigName (profile A) This caused both profiles to receive identical configuration when saving, explaining the bug where 'change B, then A gets the same changes'. The duplicate code block appears to be leftover from before PR #3732's profile isolation changes, likely kept during the merge in PR #3895. Fixes the profile state sharing bug reported after PR #3895 merge.
markijbema
added a commit
that referenced
this pull request
Nov 29, 2025
…tate sharing When editing profile B while profile A is active, the handleSubmit function had a duplicate block that was: 1. Sending updateCondensingPrompt twice (line 560 and removed duplicate) 2. Sending upsertApiConfiguration to currentApiConfigName (active profile A) instead of editingApiConfigName (profile B being edited) 3. Sending telemetrySetting twice (line 564 and removed duplicate) The duplicate upsertApiConfiguration call caused both profiles to receive identical configuration when saving, explaining the bug where 'change B, then A gets the same changes'. The duplicate code block appears to be leftover from before PR #3732's profile isolation changes, likely kept during the merge in PR #3895. Fixes the profile state sharing bug reported after PR #3895 merge.
markijbema
added a commit
that referenced
this pull request
Nov 29, 2025
…ng profile When editing profile B while profile A is active, the handleSubmit function was calling upsertApiConfiguration twice: 1. Once with editingApiConfigName (correct - saves to profile B) 2. Once with currentApiConfigName (bug - overwrites profile A with B's config) This caused the symptom where changing profile B would also change profile A. The fix removes the early duplicate calls and keeps only the later ones, ensuring upsertApiConfiguration uses editingApiConfigName to save to the correct profile being edited. Fixes the profile isolation issue introduced in PR #3732 merge (#3895).
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.