✨ feat(settings): add allowedMaxRequests feature UI and state #394
Conversation
🦋 Changeset detectedLatest commit: 2f1c838 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
- Introduce allowedMaxRequests property to manage the maximum number of auto-approved API requests. - Update ClineProvider, webviewMessageHandler, and other related components to handle allowedMaxRequests. - Modify AutoApproveMenu and SettingsView to include UI for setting allowedMaxRequests. - Enhance ExtensionStateContext to manage the state of allowedMaxRequests.
hassoncs
force-pushed
the
cline-max-requests
branch
from
90f86dd to
cfb94d6
Compare
- introduce handling for maximum auto-approved requests - increment consecutiveAutoApprovedRequestsCount and reset upon user approval - prompt user when auto-approval limit is reached with i18n support 🌐 i18n(locales): add auto-approval limit reach translations - add translations for auto-approved request limit reached prompt in multiple languages - update kilocode.json files to include new translation keys ♻ refactor(chat): handle new auto-approval max request case in ChatRow - add case handling for "auto_approval_max_req_reached" in ChatRowContent - display prompt with title, description, and button for user action
hassoncs
force-pushed
the
cline-max-requests
branch
2 times, most recently
from
8f08984 to
2f63c37
Compare
hassoncs
force-pushed
the
cline-max-requests
branch
2 times, most recently
from
e2ddbb3 to
b6e5000
Compare
- introduce AutoApprovedRequestLimitWarning component for better user feedback - enhance user interface by displaying warning for auto-approved request limits - move allowedMaxRequests retrieval closer to usage for improved code readability - add kilocode_change comment in schema for better context understanding
hassoncs
force-pushed
the
cline-max-requests
branch
from
b6e5000 to
cfe9e3b
Compare
There was a problem hiding this comment.
🔥🔥🔥
Approved for convenience sake but just with one sidenote: since AutoApprovedRequestLimitWarning is a newly added "kilocode component" (as in: it's not from our source Roo). I would prefer adding it to components/kilocode/chat. Just to keep the proper separation going, if you agree? If not also perfectly fine, lets merge it :)
|
In case it helps make a call, we’ll probably merge this one back in. Thank you! |
hassoncs
force-pushed
the
cline-max-requests
branch
2 times, most recently
from
7412cc8 to
5713f02
Compare
|
@kevinvandijk, I added a couple commits to remove the kilo specific parts then I opened a PR for Roo here: |
hassoncs
force-pushed
the
cline-max-requests
branch
from
5713f02 to
2f1c838
Compare
kevinvandijk
left a comment
kevinvandijk
left a comment
There was a problem hiding this comment.
Love that we can finally start contributing back to Roo Code! Only adding the "request changes" to block people from merging this for now. If Roo merges this that's awesome and then let's just close this and wait for that!
|
This merged on the Roo side! Closing this PR :) |
Introduce the "auto-approve request count" feature from Cline. This is the first minor UI feature I've added, so please let me know if I'm missing anything! (translations, organization, etc!)
Please see commits for details
allowedMaxRequeststo globalSettingsSchemaallowedMaxRequestsAutoApproveMenucomponentconsecutiveAutoApprovedRequestsCountand reset upon user approvalChatRowContent