feat(autocomplete): Add id field to cache for better visibility tracking #4837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add id property to FillInAtCursorSuggestion type - Update getSuggestionKey() to return the id instead of prefix/suffix/text triplet - Generate id when creating suggestions - Update tests to include id field
🦋 Changeset detectedLatest commit: e3cf991 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
Code Review SummaryStatus: No Issues Found | Recommendation: Merge OverviewThis PR adds an
Files Reviewed (5 files)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
idfield to the autocomplete cache entry and updates the visibility tracking to use the id instead of the prefix/suffix/suggestion triplet.Changes:
idproperty toFillInAtCursorSuggestiontype intypes.tsgetSuggestionKey()inAutocompleteTelemetry.tsto return the idprocessSuggestion()updateSuggestions()to ensure suggestions have an idThis provides more reliable telemetry tracking for autocomplete visibility.