Skip to content

Conversation

@kiloconnect
Copy link
Contributor

@kiloconnect kiloconnect bot commented Jan 7, 2026

Summary

This PR adds an id field to the autocomplete cache and updates visibility tracking to use that id instead of the prefix, suffix, suggestion triplet.

Changes

  • Added id property to FillInAtCursorSuggestion type in types.ts
  • Updated getSuggestionKey() in AutocompleteTelemetry.ts to return the id instead of the triplet
  • Generate unique id when creating new suggestions in processSuggestion()
  • Updated tests to include the id field in test suggestions

Files Changed

  • src/services/ghost/types.ts - Added id to FillInAtCursorSuggestion
  • src/services/ghost/classic-auto-complete/AutocompleteTelemetry.ts - Updated getSuggestionKey()
  • src/services/ghost/classic-auto-complete/GhostInlineCompletionProvider.ts - Generate id in processSuggestion()
  • src/services/ghost/classic-auto-complete/__tests__/AutocompleteTelemetry.test.ts - Updated test helper

@changeset-bot
Copy link

changeset-bot bot commented Jan 7, 2026

🦋 Changeset detected

Latest commit: ef11479

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kiloconnect
Copy link
Contributor Author

kiloconnect bot commented Jan 7, 2026

Code Review Summary

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
.changeset/funny-kiwis-begin.md N/A Empty changeset file - needs proper content with package name, version bump type, and description

Details:

The changeset file is empty. According to the project's AGENTS.md rules, each PR requires a changeset with proper format:

---
"kilo-code": patch
---

Brief description of the change

Please add the appropriate content describing this change (adding id field to FillInAtCursorSuggestion for unique suggestion tracking).

Files Reviewed (5 files)
  • .changeset/funny-kiwis-begin.md - 1 issue (empty changeset)
  • src/services/ghost/types.ts - No issues
  • src/services/ghost/classic-auto-complete/AutocompleteTelemetry.ts - No issues
  • src/services/ghost/classic-auto-complete/GhostInlineCompletionProvider.ts - No issues
  • src/services/ghost/classic-auto-complete/__tests__/AutocompleteTelemetry.test.ts - No issues

Code Quality Notes:

The code changes themselves look well-structured:

  • The id field is properly added to the FillInAtCursorSuggestion interface
  • All creation sites are updated to generate UUIDs using crypto.randomUUID()
  • The getSuggestionKey function is correctly updated to use the new id field
  • Test helper is updated to include the id field

Fix these issues in Kilo Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant