-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Kilo Icon on editor actions #4862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kilo Icon on editor actions #4862
Conversation
🦋 Changeset detectedLatest commit: 10ce725 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| "command": "kilo-code.popoutButtonClicked", | ||
| "title": "%command.openInEditor.title%", | ||
| "icon": "$(link-external)" | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WARNING: Duplicate command definition
The command kilo-code.popoutButtonClicked is already defined at lines 166-169 in this file. This duplicate definition should be removed to avoid potential issues with VS Code's command registration.
| }, | |
| }, |
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (4 files)
|
hassoncs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I pulled it down, and it works great! My only question is, why do we need a new open event? kilo-code.open vs just using kilo-code.popoutButtonClicked again?
open: () => openClineInNewTab({ context, outputChannel }), // kilocode_change
openInNewTab: () => openClineInNewTab({ context, outputChannel }),
|

Context
This PR adds a Kilo Code icon button to the editor toolbar that provides quick access to open Kilo Code from any editor context. This improves discoverability and accessibility by making it easier for users to launch Kilo Code without needing to navigate to the sidebar or use keyboard shortcuts.
Implementation
The implementation involves three main changes:
Command Registration (
packages/types/src/vscode.ts): Added a new"open"command ID to the command registry to enable the new toolbar action.Command Handler (
src/activate/registerCommands.ts): Registered theopencommand handler that reuses the existingopenClineInNewTabfunctionality, ensuring consistent behavior with other "open" actions.UI Integration (
src/package.json):assets/icons/)"when": "true"to make it always visibleThe implementation follows the existing pattern used by other editor actions and properly marks Kilo Code-specific changes with
kilocode_changecomments to facilitate future upstream merges.Screenshots
How to Test