feat: show whole block when current line has no word characters #4876
+21
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the current line prefix contains no word characters (e.g., only whitespace/indentation after typing comma and Enter in an array of objects), show the whole multi-line suggestion instead of truncating to the first line. This improves the autocomplete experience when adding new items to arrays or objects, where the user expects to see the complete suggested block. Also add tests to cover this scenario and fix existing test that was incorrectly expecting truncation when the current line has only whitespace.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When the current line prefix contains no word characters (e.g., only whitespace/indentation after typing comma and Enter in an array of objects), show the whole multi-line suggestion instead of truncating to the first line.
Problem
When editing an array of objects and typing
,thenEnter, the cursor is on a new line with only whitespace/indentation. Previously, multi-line suggestions would be truncated to just the first line (e.g., showing only{instead of the complete object block).Solution
Add a check in
shouldShowOnlyFirstLineto returnfalse(show whole block) when the current line prefix contains no word characters (\w).Changes
shouldShowOnlyFirstLinefunctionTesting
All 111 tests pass.