remove red background in task when task could not be found #4880
Conversation
we had multiple people give us feedback that this triggers when the task is actually there, so this does more harm than good now
🦋 Changeset detectedLatest commit: 909bca7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
TODO: also revert 942e605 |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge OverviewThis PR cleanly removes the "file not found" red background feature from task history items. The changes are well-structured:
The explanatory comments in Files Reviewed (4 files)
|
- Remove fileNotfound field from HistoryItem schema - Remove setTaskFileNotFound method from ClineProvider - Restore original deleteTaskFromState behavior when task file is not found This completes the revert of PR #938's fileNotFound feature which was marking tasks with a red background when their files couldn't be found.
src/core/webview/ClineProvider.ts
Outdated
| // FIXME: this seems to happen sometimes when the json file doesnt save to disk for some reason | ||
| // await this.deleteTaskFromState(id) // kilocode_change disable confusing behaviour | ||
| await this.setTaskFileNotFound(id) // kilocode_change | ||
| await this.deleteTaskFromState(id) |
There was a problem hiding this comment.
I think we want to comment this out?
chrarnoldus
left a comment
chrarnoldus
left a comment
There was a problem hiding this comment.
do we want a changeset?
we had multiple people give us feedback that this triggers when the task is actually there, so this does more harm than good now