FileReader implement Read Trait for The case like reading orc file

[awol2005ex]

FileReader implement Read Trait for The case like reading orc file

[Kimahriman]

I don't really want to implement a Sync trait in this library. If you need a Read you should be able to create your own wrapper object and implement Read on it with whatever semantics you need.

[awol2005ex]

I don't really want to implement a Sync trait in this library. If you need a Read you should be able to create your own wrapper object and implement Read on it with whatever semantics you need.

The attr “position” is private so that the way of wrapper is impossible 。And “Read” Trait is very useful like that you can copy file very easy by the current tools。

[Kimahriman]

The attr “position” is private so that the way of wrapper is impossible

You can use the public remaining function to do the same thing

[awol2005ex]

The attr “position” is private so that the way of wrapper is impossible

You can use the public remaining function to do the same thing

But FileReader is not impl Clone

[Kimahriman]

But FileReader is not impl Clone

If you need clone it probably isn't working correctly, since you would modify a cloned position instead of the original position. This seems to work fine:

struct FileReaderWrapper {
    inner: FileReader,
}

impl Read for FileReaderWrapper {
    fn read(&mut self, buf: &mut [u8]) -> std::io::Result<usize> {
        futures::executor::block_on(async { Ok(self.inner.read_buf(buf).await.unwrap()) })
    }
}