Support automatic selection of whether to load kprobe #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jundizhou <jundizhou@harmonycloud.cn>
jundizhou
changed the title
|
I review the code of agent-libs, the name SCAP_UNKNOW_KPROBE cannot be used for the program type of tracepoint (scap_bpf.c, line: 649, 837). I think some name like SCAP_LOAD_FAILED may be better. For this commit, I think the update aims to tolerate some errors of loading kprobe programs, changing the title may be better. Besides, I wonder if the program will output error info when skip loading kprobe programs |
|
我会修改unknow->unkown，代码逻辑只有kprobe会返回这个类型。 |
looks like tracepoint may reach this branch. scap_bpf.c |
Signed-off-by: jundizhou <jundizhou@harmonycloud.cn>
sanyangji
previously approved these changes
Sep 20, 2022
|
Please update the changelog. I suggest this as an enhancement. |
Signed-off-by: jundizhou <jundizhou@harmonycloud.cn>
Signed-off-by: jundizhou <jundizhou@harmonycloud.cn>
dxsup
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jundizhou jundizhou@harmonycloud.cn
Description
Related Issue
Motivation and Context
How Has This Been Tested?