scheduled cleaning in javatraces , and add null pointer checking #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 27, 2023 21:00
Signed-off-by: Hui <anthonyhui@126.com>
…ure expiration time and cleanup interval through the configuration file.Fixed a bug in javatrace that could cause a null pointer and crash. Signed-off-by: Hui <anthonyhui@126.com>
dxsup
reviewed
May 11, 2023
Signed-off-by: Hui <anthonyhui@126.com>
Signed-off-by: AnthonyHui <48346142+hwz779866221@users.noreply.github.com>
Signed-off-by: AnthonyHui <48346142+hwz779866221@users.noreply.github.com>
Signed-off-by: Hui <anthonyhui@126.com>
dxsup
reviewed
May 19, 2023
collector/pkg/component/analyzer/cpuanalyzer/cpu_analyzer_test.go
Outdated
Show resolved
Hide resolved
collector/pkg/component/analyzer/cpuanalyzer/cpu_analyzer_test.go
Outdated
Show resolved
Hide resolved
collector/pkg/component/analyzer/cpuanalyzer/cpu_analyzer_test.go
Outdated
Show resolved
Hide resolved
dxsup
previously approved these changes
May 19, 2023
added 6 commits
May 23, 2023 16:49
Signed-off-by: Hui <anthonyhui@126.com>
added 2 commits
May 24, 2023 11:46
Signed-off-by: Hui <anthonyhui@126.com>
dxsup
reviewed
May 31, 2023
collector/pkg/component/analyzer/cpuanalyzer/delete_javatrace.go
Outdated
Show resolved
Hide resolved
dxsup
reviewed
May 31, 2023
|
Please use |
added 2 commits
June 1, 2023 17:15
Signed-off-by: anthonyhui <anthonyhui@126.com>
added 4 commits
August 16, 2023 18:16
Signed-off-by: anthonyhui <anthonyhui@126.com>
Signed-off-by: anthonyhui <anthonyhui@126.com>
dxsup
approved these changes
Sep 1, 2023
dxsup
pushed a commit
to dxsup/kindling
that referenced
this pull request
Sep 1, 2023
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now javatrace will regularly clean up the space, and users can configure expiration time and cleanup interval through the configuration file.
Fixed a bug in javatrace that could cause a null pointer and crash.
Related Issue
When detecting middleware similar to ShardingSphere, javatrace will experience null pointer crashes in cpuanalyzer.
Due to the lack of scheduled cleaning in javatrace, it may cause memory leaks.
Motivation and Context
Added null pointer checking in
analyzerJavaTraceTime.Scheduled cleaning has been configured in
javatrace, and related parameters can be configured inkindling-collector-config.yml.