Refactor the data format of on/off CPU events to array #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn> Co-authored-by: sangyangji <songyujie@zju.edu.cn>
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
hocktea214
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor the data format of on/off CPU events from "string" to "array".
Related Issue
This change on the agent is accompanied by PR #512, which includes corresponding changes on the front end.
Motivation and Context
At present, the on/off CPU events are stored as a "string" type in the "cpuEvent" field, despite being inherently arrays. This PR aims to refactor the data format to use the "array" type instead, to simplify the processing code. However, it's crucial to note that this is a breaking change, meaning that the new data cannot be parsed using previous versions of the front-end, and conversely, the old data format cannot be parsed using the new version of the front-end.