Batch event retrieval in cgo for performance enhancement #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YDMsama <ydmsama@gmail.com>
Signed-off-by: YDMsama <127646431+YDMsama@users.noreply.github.com>
|
unfinished |
…interval Signed-off-by: YDMsama <ydmsama@gmail.com>
YDMsama
force-pushed
the
new_branch_for_bug2
branch
from
ccdfa69
to
9b4082c
Compare
dxsup
previously approved these changes
Aug 24, 2023
Signed-off-by: YDMsama <ydmsama@gmail.com>
dxsup
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduced a new function in cgo to retrieve multiple events in a single call, aiming to improve the efficiency of event processing. Instead of fetching one event at a time, the system can now fetch up to a predefined number of events, reducing the overhead of function calls and potentially improving the overall throughput of the event handling mechanism.
Changes made:
Added a new function getKindlingEvents in cgo_func.cpp which calls the get_events function in kindling.cpp.
The get_events function in kindling.cpp is designed to fetch multiple events up to a defined maximum (MAX_EVENTS).
Modified the startGetEvent function in Go to handle the batch of events returned by the new getKindlingEvents function.
How Has This Been Tested?
The compiled image runs normally.