Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bluetooth settings in light of user feedback #289

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Update bluetooth settings in light of user feedback #289

merged 1 commit into from
Dec 6, 2023

Conversation

ReFil
Copy link
Collaborator

@ReFil ReFil commented Dec 6, 2023

No description provided.

@ReFil
Copy link
Collaborator Author

ReFil commented Dec 6, 2023

Should address #282

@ReFil ReFil merged commit 2055aa2 into KinesisCorporation:V3.0 Dec 6, 2023
1 check passed
@ReFil ReFil mentioned this pull request Dec 6, 2023
Closed
alok added a commit to alok/Adv360-Pro-ZMK that referenced this pull request Dec 6, 2023
@alok
Merge remote-tracking branch 'upstream/V3.0'
baf0175 
* upstream/V3.0:
  Update bluetooth settings in light of user feedback (KinesisCorporation#289)
  Revert "Add version macro to keymap.json (KinesisCorporation#269)"
  Add version macro to keymap.json (KinesisCorporation#269)
  Changelog new base ZMK update (KinesisCorporation#268)
  Version compiled FW with automatic macro (KinesisCorporation#267)
  Document new NKRO settings (KinesisCorporation#264)
  Improve documentation based on feedback (KinesisCorporation#260)
  Update reset file
  Update ZMK (KinesisCorporation#248)
  Further documentation work (KinesisCorporation#241)
  Fix shell check warnings (KinesisCorporation#242)
  Readme rewrite (KinesisCorporation#222)
  Add CHANGELOG (KinesisCorporation#221)
fred-drake pushed a commit to fred-drake/Adv360-Keyboard that referenced this pull request Dec 17, 2023
@ReFil @fred-drake
Update bluetooth settings in light of user feedback (KinesisCorporati…
d890f61 
…on#289)
moritzschatz pushed a commit to moritzschatz/Adv360-Pro-ZMK that referenced this pull request Jan 3, 2024
@ReFil @moritzschatz
Update bluetooth settings in light of user feedback (KinesisCorporati…
51200e7 
…on#289)
moritzschatz pushed a commit to moritzschatz/Adv360-Pro-ZMK that referenced this pull request Jan 3, 2024
@ReFil @moritzschatz
Update bluetooth settings in light of user feedback (KinesisCorporati…
6728db2 
…on#289)
@gshpychka
Copy link

Can you list what the changes actually do and affect? Will commenting out CONFIG_BTC_PRIVACY=n result in us being unable to enter the password on MacOS login screen?

gshpychka pushed a commit to gshpychka/Adv360-Pro-ZMK that referenced this pull request Jan 4, 2024
@ReFil @gshpychka
Update bluetooth settings in light of user feedback (KinesisCorporati…
a56cf22 
…on#289)
@ReFil
Copy link
Collaborator Author

ReFil commented Jan 4, 2024

@gshpychka The bluetooth LE connection parameters have been changed to improve compatibility with macOS. setting CONFIG_BT_PRIVACY=n is functionally the same as commenting it out so nothing has changed in that regard

@gshpychka
Copy link

@gshpychka The bluetooth LE connection parameters have been changed to improve compatibility with macOS. setting CONFIG_BT_PRIVACY=n is functionally the same as commenting it out so nothing has changed in that regard

Understood, thanks. Still, can you clarify what those settings did and what exactly changed?

@ReFil
Copy link
Collaborator Author

ReFil commented Jan 5, 2024

The settings controlled some low level parameters of the Bluetooth connection. They were set according to the apple accessory device specification at the time. A few months ago Apple revised the accessory specification and we changed our settings accordingly

noseworthy pushed a commit to noseworthy/Adv360-Pro-ZMK that referenced this pull request Jan 16, 2024
@ReFil @noseworthy
Update bluetooth settings in light of user feedback (KinesisCorporati…
da6bb71 
…on#289)
Coobaha added a commit to Coobaha/Adv360-Pro-ZMK that referenced this pull request Jan 17, 2024
@Coobaha
Merge remote-tracking branch 'upstream/v3.0' into V3.0
8286cff 
# By ReFil (7) and others
# Via GitHub
* upstream/v3.0:
  Update Makefile variables (KinesisCorporation#335)
  Base ZMK update (KinesisCorporation#326)
  Prefer `tr` to ${char^^}, which does not work on older bash versions (KinesisCorporation#303)
  Add version macro (KinesisCorporation#300)
  Add pull request template (KinesisCorporation#293)
  Revert "Updated keymap"
  Revert "Updated keymap"
  Updated keymap
  Updated keymap
  Make get_version use bash from $PATH (KinesisCorporation#287)
  Update bluetooth settings in light of user feedback (KinesisCorporation#289)

# Conflicts:
#	Makefile
sanderdrummer added a commit to sanderdrummer/Adv360-Pro-ZMK that referenced this pull request Feb 8, 2024
@sanderdrummer @ReFil
@humblehacker @adv360proapp @jjowdy @huber-th
Update (#8)
7624144 
* feat: update keymap

* Update bluetooth settings in light of user feedback (KinesisCorporation#289)

* Make get_version use bash from $PATH (KinesisCorporation#287)

* Make get_version use bash from $PATH

* Update CHANGELOG.md

---------

Co-authored-by: ReFil <31960031+ReFil@users.noreply.github.com>

* Updated keymap

* Updated keymap

* Revert "Updated keymap"

This reverts commit 18e664a.

* Revert "Updated keymap"

This reverts commit 9fc6c62.

* Add pull request template (KinesisCorporation#293)

* Add pull request template

* Update CHANGELOG.md

* Add version macro (KinesisCorporation#300)

* Prefer `tr` to ${char^^}, which does not work on older bash versions (KinesisCorporation#303)

* Prefer `tr` to ${char^^}, which does not work on older bash versions

* Update CHANGELOG.md

---------

Co-authored-by: ReFil <31960031+ReFil@users.noreply.github.com>

* Base ZMK update (KinesisCorporation#326)

* Update Makefile variables (KinesisCorporation#335)

* Makefile enhancements to optimize local workflows (KinesisCorporation#363)

- Enhance the Makefile to enable firmware building exclusively for the left side.

To modify the keymap, flashing only the left side's firmware suffices.

This change facilitates the creation of firmware for the left side only,
thereby expediting the build process.

Usage: make left

This update maintains existing functionality. Without specifying the
left target, firmware for both halves will be generated.

- Add separate make targets to clean firmware and docker image

Add targets clean_firmware and clean_image independently while maintaing clean to run both

- Ensure files modified by the build process are reset at the end

The current build process dynamically generates the content of the version macro
in config/version.dtsi to enable users to print out the precise version and commit
the firmware was built on via a keybinding on the keymap.

This change ensurs that the changes to this macro file are reset at the end of the
build process to ensure it isn't shown as modified and added to keymap commit changes.

* feat: add f keys

---------

Co-authored-by: ReFil <31960031+ReFil@users.noreply.github.com>
Co-authored-by: David Whetstone <humblehacker@users.noreply.github.com>
Co-authored-by: adv360proapp[bot] <105741512+adv360proapp[bot]@users.noreply.github.com>
Co-authored-by: Jim Jowdy <jjowdy@gmail.com>
Co-authored-by: Thomas Huber <113915837+huber-th@users.noreply.github.com>
tricktux pushed a commit to tricktux/Adv360-Pro-ZMK that referenced this pull request Feb 10, 2024
@ReFil @tricktux
Update bluetooth settings in light of user feedback (KinesisCorporati…
a4b580c 
…on#289)
OAGr added a commit to OAGr/Adv360-Pro-ZMK-v1 that referenced this pull request Mar 2, 2024
@OAGr
Merge branch 'V3.0' into v3-test
54d0289 
* V3.0: (57 commits)
  Fix version.dtsi is reset after local firmware build (KinesisCorporation#385)
  Update build workflows (KinesisCorporation#376)
  Makefile enhancements to optimize local workflows (KinesisCorporation#363)
  Update Makefile variables (KinesisCorporation#335)
  Base ZMK update (KinesisCorporation#326)
  Prefer `tr` to ${char^^}, which does not work on older bash versions (KinesisCorporation#303)
  Add version macro (KinesisCorporation#300)
  Add pull request template (KinesisCorporation#293)
  Revert "Updated keymap"
  Revert "Updated keymap"
  Updated keymap
  Updated keymap
  Make get_version use bash from $PATH (KinesisCorporation#287)
  Update bluetooth settings in light of user feedback (KinesisCorporation#289)
  Revert "Add version macro to keymap.json (KinesisCorporation#269)"
  Add version macro to keymap.json (KinesisCorporation#269)
  Changelog new base ZMK update (KinesisCorporation#268)
  Version compiled FW with automatic macro (KinesisCorporation#267)
  Document new NKRO settings (KinesisCorporation#264)
  Improve documentation based on feedback (KinesisCorporation#260)
  ...
ztomer pushed a commit to ztomer/Adv360-Pro-ZMK that referenced this pull request Apr 16, 2024
@ReFil @ztomer
Update bluetooth settings in light of user feedback (KinesisCorporati…
e32906e 
…on#289)
zemackdaddy pushed a commit to zemackdaddy/Adv360-Pro-ZMK that referenced this pull request Jul 7, 2024
@ReFil
Update bluetooth settings in light of user feedback (KinesisCorporati…
0d9dcf4 
…on#289)
jan-l pushed a commit to jan-l/Adv360-Pro-ZMK that referenced this pull request Aug 28, 2024
@ReFil @jan-l
Update bluetooth settings in light of user feedback (KinesisCorporati…
16defd9 
…on#289)
martypenner added a commit to martypenner/Adv360-Pro-ZMK that referenced this pull request Nov 6, 2024
@martypenner
Merge branch 'V3.0' into V2.0
9801a4f 
* V3.0: (40 commits)
  Changelog update (KinesisCorporation#448)
  Minor docs update (KinesisCorporation#445)
  Document new layer colors and modifier color configuration option (KinesisCorporation#431)
  Zephyr 3.5 Update (KinesisCorporation#426)
  Fix Makefile errors that prevent builds on macOS (KinesisCorporation#409)
  Fix version.dtsi is reset after local firmware build (KinesisCorporation#385)
  Update build workflows (KinesisCorporation#376)
  Makefile enhancements to optimize local workflows (KinesisCorporation#363)
  Update Makefile variables (KinesisCorporation#335)
  Base ZMK update (KinesisCorporation#326)
  Prefer `tr` to ${char^^}, which does not work on older bash versions (KinesisCorporation#303)
  Add version macro (KinesisCorporation#300)
  Add pull request template (KinesisCorporation#293)
  Revert "Updated keymap"
  Revert "Updated keymap"
  Updated keymap
  Updated keymap
  Make get_version use bash from $PATH (KinesisCorporation#287)
  Update bluetooth settings in light of user feedback (KinesisCorporation#289)
  Revert "Add version macro to keymap.json (KinesisCorporation#269)"
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ReFil @gshpychka