Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear queue when Atum button is shift clicked #27

Closed
wants to merge 0 commits into from

Conversation

tesselslate
Copy link
Contributor

The text of Atum's Stop Resets & Quit button changes to Clear Queue when shift is held down. Pressing the button will stop SeedQueue.

The button will not change when SeedQueue is inactive.

b.mp4

Closes #11

@KingContaria KingContaria self-requested a review August 11, 2024 18:23
Copy link
Owner

@KingContaria KingContaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly codestyle nitpicks + 1 actual feature request

Copy link
Owner

@KingContaria KingContaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, I will hold off on merging in case a 1.0.2 is released for some hotfix, this PR should be part of 1.1
Only thing left is discuss with mods if they are okay with the clearing screen to show during a run.

@KingContaria
Copy link
Owner

Alright this is a more contested topic than i thought, so merge might have to be delayed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow queue to be cleared while in a run
2 participants