Add support for weak elf symbols
#242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a quick fix for crashes when importing file that contain `weak` symbols. This only treats it as `GLOBAL`, and a better implementation would be to handle precedence more appropriately
|
Yeah, that's definitely better than not working at all - thanks! I guess it will work as long as the symbol only appears in one translation unit, though for more realistic template and inline function usage scenarios deduplication would need to be implemented... in general the linking armips performs is extremely primitive, so it would need a bigger rework. |
|
Any chance we could get a release with this? It's been a while since the last one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix for crashes when importing file that contain
weaksymbols.This only treats it as
GLOBAL, and a better implementation would be to handle precedence more appropriately