Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📜Remove hardcoded dotnet version reference #321

Conversation

LeaDevelop
Copy link
Contributor

@LeaDevelop LeaDevelop commented Oct 13, 2024

Description:

To allow this pull request to be merged, please make sure that the following items of this pull request are complete.

This pull request closes #320

✅The pull request head branch must be a feature branch with the syntax 'feature/-sync-testing'.
✅The pull request base branch must be a 'main' or 'preview' branch..
✅The pull request head branch contains a valid issue number.
✅The pull request title matches the linked issue title exactly.
✅The pull request assignees match the assignees of the issue.
✅The pull request labels match the labels of the issue.
✅The pull request organizational projects match the organizational projects of the issue.
✅The pull requests milestone matches the milestone of the issue.


Additional Info:

  1. Pull requests are automatically synced with the associated issue upon creation by one of the KinsonDigital workflow bots.
  2. The associated issue is the issue number that is embedded in the pull request head branch.
  3. The list above will be automatically updated as the pull request's various settings match or do not match the associated issue.
  4. To manually sync the pull request to the issue, create a comment with the [run-sync] command.

    Note You must be an admin member of the organization to use this command.


  • Sync with the issue. Use this to enable or disable this pull request from syncing with its associated issue.

- we don't specify version for easier doc maintenance
- easier for readers who are new on game dev adventure
@LeaDevelop LeaDevelop marked this pull request as ready for review October 13, 2024 14:08
@CalvinWilkinson CalvinWilkinson added low-priority Low Priority 📜guide-doc-changes Add or change guide documentation labels Oct 15, 2024
Co-authored-by: Calvin Wilkinson <kinsondigital@gmail.com>
@LeaDevelop
Copy link
Contributor Author

@CalvinWilkinson any other corrections, or is this version fine now?

@CalvinWilkinson
Copy link
Member

CalvinWilkinson commented Oct 29, 2024

@CalvinWilkinson any other corrections, or is this version fine now?

I think that is perfect. The only other thing is that we should make the exact same change to the rest of the versions of the docs.

That would be these other versions shown below:
image

I should of had that in the issue but I did not think anybody was going to pick this up but me. Sorry about that!

@LeaDevelop
Copy link
Contributor Author

No worries, thanks for sharing where exactly changes should be I'll take care of it now

- we don't specify version for easier doc maintenance
@CalvinWilkinson CalvinWilkinson merged commit 24b7c5e into KinsonDigital:main Nov 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜guide-doc-changes Add or change guide documentation low-priority Low Priority
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

📜Remove hardcoded dotnet version reference
2 participants