Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧Add try catch around JSON parsing #31

Closed
6 tasks done
CalvinWilkinson opened this issue Jun 26, 2024 · 0 comments · Fixed by #39
Closed
6 tasks done

🚧Add try catch around JSON parsing #31

CalvinWilkinson opened this issue Jun 26, 2024 · 0 comments · Fixed by #39
Assignees
Labels
💎enhancement An improvement on something low-priority Low Priority preview Done while in preview

Comments

@CalvinWilkinson
Copy link
Member

CalvinWilkinson commented Jun 26, 2024

Complete The Item Below

  • I have updated the title without removing the 🚧 emoji.

Description

Add try-catch blocks around all JSON parsing code to properly throw a meaningful error message stating that the JSON data could not be parsed and is probably malformed.

Also, include the error message from the original error in the error message.

Acceptance Criteria

The items to complete to satisfy the Definition of Done.

ToDo Items

The items to complete to satisfy the Definition of Done.

Issue Dependencies

No response

Related Work

No response

Additional Information:

Unit Tests

Reasons for local unit test execution:

  • Unit tests might pass locally but not in the CI environment during the status check process or vice-versa.
  • Tests might pass on the developer's machine but not necessarily on the code reviewer's machine.
  • If you notice that the test status check has passed but the test failed locally, please notify a project maintainer!

💡Warning💡
If the unit tests pass remotely and are not executed locally, this means we could be letting a bug slip into production.
Though bugs will always exist in some capacity, we should all do our part to help prevent them from happening.

Change Type Labels

Change Type Label
Bug Fixes 🐛bug
Breaking Changes 🧨breaking changes
New Feature ✨new feature
CICD Changes ♻️cicd
Config Changes ⚙️config
Performance Improvements 🏎️performance
Code Doc Changes 🗒️documentation/code
Product Doc Changes 📝documentation/product

Priority Type Labels

Priority Type Label
Low Priority low priority
Medium Priority medium priority
High Priority high priority

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@CalvinWilkinson CalvinWilkinson added low-priority Low Priority preview Done while in preview 💎enhancement An improvement on something labels Jun 26, 2024
@CalvinWilkinson CalvinWilkinson self-assigned this Jun 26, 2024
@CalvinWilkinson CalvinWilkinson added this to the v1.0.0-preview.4 milestone Jun 26, 2024
CalvinWilkinson added a commit that referenced this issue Jun 27, 2024
CalvinWilkinson added a commit that referenced this issue Jun 27, 2024
* Start work for issue #31

* enhance: catch json parsing errors and print friendly error msg

* ci: catch json parse errors

* deps,refactor: replace crayon dependency with built in deno log colors

* refactor: change name of github console log functions

* config: add deno task to reload cache

* deps: update deno lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💎enhancement An improvement on something low-priority Low Priority preview Done while in preview
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant