Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧Add a new prep release setting #50

Closed
5 tasks done
CalvinWilkinson opened this issue Sep 20, 2024 · 0 comments · Fixed by #51
Closed
5 tasks done

🚧Add a new prep release setting #50

CalvinWilkinson opened this issue Sep 20, 2024 · 0 comments · Fixed by #51
Assignees
Labels
high-priority High Priority ✨new-feature New feature that does not exist preview Done while in preview

Comments

@CalvinWilkinson
Copy link
Member

CalvinWilkinson commented Sep 20, 2024

Complete The Item Below

  • I have updated the title without removing the 🚧 emoji.

Description

Add a new setting to the prepare release config settings and process whose values will contain the string of characters to be trimmed from the start of the version.

An excellent example of this is for software where the character v is not allowed as the first character for a version string when updating the version. One example is Tauri. Tauri enforces semantic versioning but does not allow the version to start with the letter v

  1. This new setting should be optional
  2. The name of the setting should be trimFromStartOfVersion
  3. The property should of type string
  4. The schema should be updated

Acceptance Criteria

The items to complete to satisfy the Definition of Done.

ToDo Items

The items to complete to satisfy the Definition of Done.

Issue Dependencies

No response

Related Work

No response

Additional Information:

Unit Tests

Reasons for local unit test execution:

  • Unit tests might pass locally but not in the CI environment during the status check process or vice-versa.
  • Tests might pass on the developer's machine but not necessarily on the code reviewer's machine.
  • If you notice that the test status check has passed but the test failed locally, please notify a project maintainer!

💡Warning💡
If the unit tests pass remotely and are not executed locally, this means we could be letting a bug slip into production.
Though bugs will always exist in some capacity, we should all do our part to help prevent them from happening.

Change Type Labels

Change Type Label
Bug Fixes 🐛bug
Breaking Changes 🧨breaking-changes
New Feature ✨new-feature
CICD Changes ♻️cicd
Config Changes ⚙️config
Performance Improvements 🏎️performance
Code Doc Changes 🗒️documentation/code
Product Doc Changes 📝documentation/product

Priority Type Labels

Priority Type Label
Low Priority low priority
Medium Priority medium priority
High Priority high priority

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@CalvinWilkinson CalvinWilkinson added high-priority High Priority preview Done while in preview ✨new-feature New feature that does not exist labels Sep 20, 2024
@CalvinWilkinson CalvinWilkinson self-assigned this Sep 20, 2024
@CalvinWilkinson CalvinWilkinson added this to the v1.0.0-preview.6 milestone Oct 2, 2024
CalvinWilkinson added a commit that referenced this issue Oct 2, 2024
CalvinWilkinson added a commit that referenced this issue Oct 2, 2024
* Start work for issue #50

* feat: add setting to trim the start of version used for prep releases

* chore: add code docs

* refactor: remove unused async await keywords

* config: create deno task for linting

* refactor: change code to meet coding standards

* ci: improve format and lint status check workflows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high-priority High Priority ✨new-feature New feature that does not exist preview Done while in preview
Projects
Status: ✅Done
Development

Successfully merging a pull request may close this issue.

1 participant