Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always show Approve/Reject buttons when server has review disabled #3202

Closed
leplatrem opened this issue Mar 26, 2024 · 0 comments · Fixed by #3207
Closed

Always show Approve/Reject buttons when server has review disabled #3202

leplatrem opened this issue Mar 26, 2024 · 0 comments · Fixed by #3207
Assignees
@alexcottner
Labels
enhancement ux

Comments

@leplatrem
Copy link
Contributor

When review is disabled, users can approve their own changes. But the Admin UI does not show the approve/reject buttons.

The only way for them to do it is to use the CLI:

$ echo '{"data":{"status": "to-resign"}}' | http PATCH https://remote-settings-dev.allizom.org/v1/buckets/main-workspace/collections/product-integrity "Authorization:$BEARER_TOKEN"
@leplatrem leplatrem changed the title Always show _Approve_ button when server has review disabled Always show Approve/Reject button when server has review disabled Mar 26, 2024
@leplatrem leplatrem changed the title Always show Approve/Reject button when server has review disabled Always show Approve/Reject buttons when server has review disabled Mar 26, 2024
@alexcottner alexcottner self-assigned this Apr 5, 2024
@alexcottner alexcottner mentioned this issue Apr 5, 2024
Merged
alexcottner added a commit that referenced this issue Apr 23, 2024
@alexcottner
Fixes #3202: allowing self review when to_review_enabled is false (#…
0a2b30d 
…3207)

* allowing self review when o_review_enabled is false
* refactored and adjusted tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexcottner alexcottner

Labels
enhancement ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #3202: allowing self review when to_review_enabled is false Kinto/kinto-admin
2 participants
@leplatrem @alexcottner