-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix history diff viewing #563
Conversation
@glasserc this partially reverts what was done in f2e9326?w=1#diff-783a4918ddce584cff30089389577b76, I'm not sure why you made the change in the To review this PR, I would recommend using the "no whitespace diff" trick: https://github.com/Kinto/kinto-admin/pull/563/files?w=1 The change is minimal, and consists of reverting the modifications to the markup made in the two commits mentioned in the description of #562. |
I think I now understand why the change was made, and I need to find another way to fix it. Will ping you @glasserc whenever I have a solution. |
Ok, I think I found a workaround to make flow happy, ping @glasserc. |
you can post a screenshot to help figuring out the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was surprised to discover that a <table>
can contain "zero or more" <tbody>
elements, so I guess this is fine.
Yeah @leplatrem the fix makes it display the diff taking the whole width of the table, as it used to: |
Excellent thanks :) |
Fixes #562