Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix history diff viewing #563

Merged
merged 2 commits into from
Jul 2, 2018
Merged

Conversation

magopian
Copy link
Contributor

Fixes #562

@magopian
Copy link
Contributor Author

magopian commented Jun 29, 2018

@glasserc this partially reverts what was done in f2e9326?w=1#diff-783a4918ddce584cff30089389577b76, I'm not sure why you made the change in the HistoryTable component, maybe I'm missing something?

To review this PR, I would recommend using the "no whitespace diff" trick: https://github.com/Kinto/kinto-admin/pull/563/files?w=1

The change is minimal, and consists of reverting the modifications to the markup made in the two commits mentioned in the description of #562.

@magopian magopian requested a review from glasserc June 29, 2018 09:43
@magopian
Copy link
Contributor Author

I think I now understand why the change was made, and I need to find another way to fix it. Will ping you @glasserc whenever I have a solution.

@magopian
Copy link
Contributor Author

Ok, I think I found a workaround to make flow happy, ping @glasserc.

@leplatrem
Copy link
Contributor

you can post a screenshot to help figuring out the changes

Copy link
Contributor

@glasserc glasserc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was surprised to discover that a <table> can contain "zero or more" <tbody> elements, so I guess this is fine.

@magopian
Copy link
Contributor Author

Yeah @leplatrem the fix makes it display the diff taking the whole width of the table, as it used to:

screen shot 2018-06-29 at 17 56 03

@leplatrem leplatrem merged commit f4f6d98 into Kinto:master Jul 2, 2018
@leplatrem
Copy link
Contributor

Excellent thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants