Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #949: fix history list from signoff diff details #950

Merged
merged 3 commits into from
Jun 6, 2019
Merged

Fix #949: fix history list from signoff diff details #950

merged 3 commits into from
Jun 6, 2019

Conversation

leplatrem
Copy link
Contributor

Fix #949

@leplatrem leplatrem requested a review from glasserc June 3, 2019 14:24
glasserc
glasserc reviewed Jun 4, 2019
View reviewed changes
Copy link
Contributor

@glasserc glasserc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... are kinto history entries not dated the same as the modifications they represent?

@leplatrem
Copy link
Contributor Author

Hmm... are kinto history entries not dated the same as the modifications they represent?

Nope the history entries have their own timestamps. But you're right I should give a detailed example (tomorrow)

@leplatrem leplatrem mentioned this pull request Jun 5, 2019
Closed
@leplatrem
Copy link
Contributor Author

Comment added #949 (comment)

@glasserc
Copy link
Contributor

glasserc commented Jun 5, 2019

Thanks for the detailed explanation. I kind of wish that history entries had the same timestamp as the record that had been modified, but maybe that's unreasonable.

@leplatrem
Copy link
Contributor Author

Thanks for the detailed explanation. I kind of wish that history entries had the same timestamp as the record that had been modified, but maybe that's unreasonable.

Well, they don't.
But we have an excuse: timestamps are guarenteed to be unique per bucket/collection, whereas history entries are per bucket, which makes it difficult ;)

@leplatrem leplatrem merged commit 949bb0a into master Jun 6, 2019
@leplatrem leplatrem deleted the 949-fix-history-list branch June 6, 2019 08:48
@leplatrem leplatrem mentioned this pull request Aug 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glasserc glasserc glasserc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[signoff] History list in details view contains an extra record
2 participants
@leplatrem @glasserc