Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch config from dict to list #11

Closed
leplatrem opened this issue Jan 20, 2017 · 0 comments
Closed

Switch config from dict to list #11

leplatrem opened this issue Jan 20, 2017 · 0 comments

Comments

@leplatrem
Copy link
Contributor

We may want to send two different emails for the same event. The current approach with the keys do not allow it.

I think also that we could use attributes to filter events, like this:

[
    {
        "resource_name": "record",
        "action": "create",
        "collection_id": "certificates",
        "template": "Hi, a new record '{uri}' has just been created in the collection '{bucket_id}/{collection_id}'",
        "recipients": ['Security reviewers <security-reviews@mozilla.com>'],
        "sender": "Kinto team <developers@kinto-storage.org>"
    },
    {
        "event": "kinto_signer.events.ReviewRequested",
        "template": "Hi, a review is pending your approval on the collection '{bucket_id}/{collection_id}'",
        "recipients": ['Security reviewers <security-reviews@mozilla.com>'],
        "sender": "Kinto team <developers@kinto-storage.org>"
    }
]
leplatrem added a commit that referenced this issue Jan 24, 2017
Switch collection config from dict to list (fixes #11)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant