This repository has been archived by the owner on Apr 4, 2022. It is now read-only.
Fix testing #278
Merged
Fix testing #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be the first of many consequences from sinonjs/sinon#1586 and sinonjs/sinon#1700. I'm not sure what the final result of all of this will be -- we might not even need this sandbox any more, because a default one is created for us -- but at some point in the future, we'll probably have to rewrite everything that uses a stub(), and I prefer to wait until then to make any drastic changes. This just silences the warnings until then.
|
@leplatrem Because we now expose |
|
The only thing that comes into my mind (it's late here) is to have a condition on the server version in the tests. |
|
OK, ready for a final review on this. @leplatrem ? |
leplatrem
approved these changes
Apr 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines with Kinto/kinto#1576 to fix the current test failures in Travis.
Also, while we're here, fix the test warnings from the sinon version.