Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Browserify and Babel with TypeScript and Rollup #1061

Merged
merged 3 commits into from
Oct 2, 2019

Conversation

dstaley
Copy link
Member

@dstaley dstaley commented Sep 11, 2019

The content of this PR is the same as the previously closed PR. I must have done something to anger the Git gods because I could no longer merge upstream changes due to unrelated histories, so I just manually recreated this PR.

This is largely a replication of the work done to migrate kinto-http.js to TypeScript and Rollup. It makes the same modifications to package.json and uses essentially the exact same Rollup config.

There are, however, two small changes specific to this repo:

  1. Fixed a bug in test/adapters/IDB_test.js that could cause an index out-of-bounds error.
  2. Added a small Rollup plugin to exclude uuid from the Gecko build.
  3. Updated the cs-check command to use prettier's --check option. I think this is why the builds have been green despite the test files not matching the prettier config.

Unfortunately, it looks like some of the test files didn't follow the Prettier style, so those changes also come along in this PR. The only other changes in the test files (besides the trailing commas) is the change of import for uuid to match how it's being imported in the main library (import uuid from 'uuid/v4'

@leplatrem
Copy link
Contributor

@dstaley I'm sorry, this completely slipped through my inbox...

Is it up-to-date?

@dstaley
Copy link
Member Author

dstaley commented Oct 1, 2019

@leplatrem It is now! Once this is merged can you do an alpha release on npm? I'd love to give that a try in my TypeScript project using Kinto.

@leplatrem leplatrem merged commit b5baf9f into Kinto:master Oct 2, 2019
@leplatrem
Copy link
Contributor

Just published kinto@13.0.0-alpha.0 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants