Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostgreSQL by default ? #3

Closed
leplatrem opened this issue Feb 26, 2015 · 6 comments
Closed

PostgreSQL by default ? #3

leplatrem opened this issue Feb 26, 2015 · 6 comments
Labels

Comments

@leplatrem
Copy link
Contributor

  • put cliquet[postgresql] in requirements
  • put storage_url in config (default postgres:postgres@localhost/postgres)
@almet
Copy link
Member

almet commented Feb 26, 2015

Yes, I believe that makes the most sense to have kinto persist on disk by default. Redis / Memory are too volatile to make them defaults here.

@Natim
Copy link
Member

Natim commented Feb 26, 2015

It depends what default means, for me default are to help the dev to get started. Not default configuration for production.

Maybe the answer is not the same for kinto and cliquet on this. But IMHO the default should be something easier to setup than postgresql.

@Natim
Copy link
Member

Natim commented Feb 26, 2015

Btw on defaut Redis configuration, persistence on disk is activated.

@almet
Copy link
Member

almet commented Feb 26, 2015

If we need to differentiate between defaults for the devs and defaults for prod, then we probably should have two different set of configuration files.

I don't consider postgres to be something harder than postgres to install (but yes, that's a personal thing I believe). So, even if it is (hard to install), we should document how to install it (with a docker, yo).

I wasn't aware for redis persisting on disk by default, cool!

The suggested (and default) policy is to fsync every second. It is both very fast and pretty safe. The always policy is very slow in practice (although it was improved in Redis 2.0) – there is no way to make fsync faster than it is.

@leplatrem
Copy link
Contributor Author

PostgreSQL is a lot more easy to install than Redis (see docs), but since we don't have any other session backend implementation, using psql by default does not prevent us from running Redis!

We could consider defaulting to PostgreSQL once we have session backend running on it :)

@leplatrem
Copy link
Contributor Author

Since the default test database is postgres in cliquet, there is no database creation step

almet added a commit that referenced this issue Mar 2, 2015
almet added a commit that referenced this issue Mar 3, 2015
@Natim Natim closed this as completed Mar 5, 2015
almet added a commit that referenced this issue Mar 5, 2015
almet added a commit that referenced this issue Mar 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants