Limit network requests to current domain in Kinto Admin using CSP #1655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Natim
reviewed
May 28, 2018
kinto/plugins/admin/views.py
Outdated
| settings = { | ||
| 'authMethods': aslist(request.registry.settings.get('multiauth.policies')) | ||
| } | ||
| globalSettings = '<script>window.globalSettings = {};</script>'.format(json.dumps(settings)) |
There was a problem hiding this comment.
If we don't need to generate the settings from the installed kinto plugins, we don't need to have a python view anymore to render the html page. (except maybe to route between the index.html page and the help page but do we really?)
Natim
reviewed
May 28, 2018
kinto/plugins/admin/src/index.js
Outdated
| @@ -5,8 +5,7 @@ import * as signoffPlugin from "kinto-admin/lib/plugins/signoff"; | |||
|
|
|||
| const settings = { | |||
| maxPerPage: 50, | |||
| singleServer: document.location.toString().split('/admin/')[0], | |||
| ...window.globalSettings, | |||
There was a problem hiding this comment.
Why is this related to the CSP feature?
There was a problem hiding this comment.
I opened #1658 :)
…-Security Policies
leplatrem
force-pushed
the
csp-kinto-admin
branch
from
4b39ea6
to
810a919
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ulfr recommandation Kinto/kinto-admin#460 (comment)