Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove storage.get_all() leftovers #1961

Merged
merged 1 commit into from
Jan 6, 2019
Merged

Remove storage.get_all() leftovers #1961

merged 1 commit into from
Jan 6, 2019
+40 −38

Conversation

leplatrem
Copy link
Contributor

Ref #1624

@leplatrem leplatrem requested a review from peterbe January 4, 2019 16:56
peterbe
peterbe approved these changes Jan 4, 2019
View reviewed changes
Copy link
Contributor

@peterbe peterbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm both stunned and ashamed that this was left in there. I thought I grepped for all remaining ones. Weird.

@leplatrem leplatrem merged commit 90dca4a into master Jan 6, 2019
@leplatrem leplatrem deleted the remove-get_all-usage branch January 6, 2019 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbe peterbe peterbe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leplatrem @peterbe