-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from setup.cfg
/setup.py
to pyproject.toml
#3359
Conversation
474dce9
to
8c23eb1
Compare
8c23eb1
to
8315085
Compare
I noticed the docker image build is broken in this PR, I'll open a separate PR to run the functional tests against a freshly docker image |
@@ -0,0 +1,40 @@ | |||
# main dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious, what is the difference between these dependencies and those listed in pyproject.toml
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This requirements.in
is just the "source" of our constraints file.
And the dependencies in pyproject.toml are the final package dependencies (when installed from pip for example).
I will open an issue about that, because I'm not happy about a single requirements.txt
as a constraints file, for both our main and our extra dependencies.
Co-authored-by: grahamalama <gbeckley@mozilla.com>
Repo modernization!
requirements.in
to build the constraints file. This is messy, and would probably lead us to a wrapper like Poetry, in order to have a proper lock file. Because pip does not support hashes in editable mode, and pip-compile does not pick extra dependencies from pyproject.toml, they therefore have to be duplicated in a requirements.in file.