This repository has been archived by the owner on Aug 31, 2019. It is now read-only.
Fix File Upload #15
Merged
Fix File Upload #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gprodanov
changed the title
…ad to wrong authorization token being sent. Fix option value for following redirects.
gprodanov
changed the title
… file-upload * 'file-upload' of github.com:Kinvey/nativescript-sdk: Small refactoring. # Conflicts: # src/datastore/nativescript-filestore.ts
…-nativescript-sdk
Override the upload function to check if a file exists before attempting to upload the file. Set the content-range header correctly.
# Conflicts: # demo/.vscode/launch.json # src/filestore/common.ts # src/filestore/filestore.android.ts # src/filestore/filestore.ios.ts # src/index.ts
thomasconner
approved these changes
Jul 28, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The request URL for downloading the file from Google bucket was being encoded tiwice, which lead to wrong authorization token being sent.
Changes
Remove URI encoding since it's already encoded. Fix option value for following redirects.