Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate per-host aggregate rows #11

Merged
merged 3 commits into from
Jun 4, 2017

Conversation

dfberger
Copy link
Contributor

Useful for understanding total usage of multi-homed or dual-stack hosts.

useful to undertand usage for multi-homed and/or dual-stack hosts
keeping the display properly sorted when grouping hosts was inefficient for
event moderate numbers of hosts.  instead, just optionally compute per-host
aggregate rows and include them in the normal sort/display logic.
@Kiougar Kiougar merged commit 9352095 into Kiougar:master Jun 4, 2017
@fakuivan
Copy link
Contributor

fakuivan commented Jun 4, 2017

Could this somehow conflict with #7?

@dfberger
Copy link
Contributor Author

dfberger commented Jun 4, 2017

@fakuivan - I haven't looked carefully at #7 but this change doesn't affect the underlying data gathering (including per-address up/down calculation) which are done by the wrtbwmon package.

@Kiougar
Copy link
Owner

Kiougar commented Jun 4, 2017

I agree with @dfberger. This is supposed to group rows based on MAC address and #7 simply needed an extra case to check if IPs are the same. This should not affect #7.

@Kiougar
Copy link
Owner

Kiougar commented Jun 4, 2017

BTW, thanks for this PR. This is a nice feature. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants