-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prep 0.2.0 #27
Closed
Closed
Prep 0.2.0 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #11 |
closes #26 |
closes #21 Although the |
TODO: need to add some more/different tiff files for tests and make testing wider Also need to update the docs |
Alpha-version has been released onto pypi: https://pypi.org/project/geotiff/0.2a1/ TODO
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a discussion about the new UI for the geotiff package.
One important aspect is the ability to read tiff files in their original CRS or to convert it to any other CRS. This conversion should be done with the help of the packages
pycrs
to cover most of the codes andPyProj
to do the actual conversion.Currently, the UI looks like:
where
crs_code
is the Optional code of the tiff file, for when the file cannot be detected.There may need to be an additional parameter, say
as_crs
, to determine the CRS that the GeoTiff objects method should return its data as.Another param in the init method is the band that has the default as 0. I'm pretty sure I saw a way to this with the
tifffile
package.This becomes a bit tricky when using the
read_box()
method. Should the input coordinates be in the converted CRS or the original CRS. I think it should be in the converted CRS and be converted, within the method, back into the original CRS to cut the appropriate section out of the box. This becomes weird, however, the file and CRS orientations may not exist on the same plane. Perhaps usingnorth
,south
,east
andwest
could work for this purpose.Also, the
read()
method should return a zarr array. should also include aread_numpy()
method that returns a numpy array. perhaps alsoread_zarr()
for consistency.