Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep 0.2.0 #27

Closed
wants to merge 50 commits into from
Closed

Prep 0.2.0 #27

wants to merge 50 commits into from

Conversation

KipCrossing
Copy link
Owner

@KipCrossing KipCrossing commented Jul 13, 2021

This PR is a discussion about the new UI for the geotiff package.

One important aspect is the ability to read tiff files in their original CRS or to convert it to any other CRS. This conversion should be done with the help of the packages pycrs to cover most of the codes and PyProj to do the actual conversion.

Currently, the UI looks like:

geoTiff = GeoTiff(tiff_file, crs_code=4236)

where crs_code is the Optional code of the tiff file, for when the file cannot be detected.

There may need to be an additional parameter, say as_crs, to determine the CRS that the GeoTiff objects method should return its data as.

Another param in the init method is the band that has the default as 0. I'm pretty sure I saw a way to this with the tifffile package.


This becomes a bit tricky when using the read_box() method. Should the input coordinates be in the converted CRS or the original CRS. I think it should be in the converted CRS and be converted, within the method, back into the original CRS to cut the appropriate section out of the box. This becomes weird, however, the file and CRS orientations may not exist on the same plane. Perhaps using north, south, east and west could work for this purpose.

Also, the read() method should return a zarr array. should also include a read_numpy() method that returns a numpy array. perhaps also read_zarr() for consistency.

@KipCrossing
Copy link
Owner Author

closes #11

@KipCrossing
Copy link
Owner Author

closes #26

@KipCrossing
Copy link
Owner Author

closes #21

Although the get_coord_arrays method cannot do large arrays. We may need to implement dask to take advantage of this feature.

@KipCrossing
Copy link
Owner Author

TODO: need to add some more/different tiff files for tests and make testing wider

Also need to update the docs

@KipCrossing
Copy link
Owner Author

KipCrossing commented Jul 15, 2021

Alpha-version has been released onto pypi: https://pypi.org/project/geotiff/0.2a1/

TODO

  • Add CONTRIBUTING.md
  • Add code of conduct
  • FEATURE write geotiff
  • FEAURE tif_bBox_converted

@KipCrossing KipCrossing deleted the prep_0.2.0 branch July 15, 2021 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant