Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/serial ddl #177

Merged
merged 5 commits into from
Mar 25, 2024
Merged

Fix/serial ddl #177

merged 5 commits into from
Mar 25, 2024

Conversation

KKould
Copy link
Member

@KKould KKould commented Mar 22, 2024

What problem does this PR solve?

add mdl (MetaDataLock) to DataBase to make DDL serial

DDL is not allowed to be executed in DBTransaction. This is because MySQL will cause the transaction to be implicitly committed when Transaction executes DDL, and DDL will be executed as a separate transaction.

Issue link:

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@KKould KKould requested a review from crwen March 22, 2024 17:02
@KKould KKould self-assigned this Mar 22, 2024
@KKould KKould added bug Something isn't working enhancement New feature or request labels Mar 22, 2024
@KKould KKould merged commit 8fe905a into KipData:main Mar 25, 2024
3 checks passed
@KKould KKould mentioned this pull request Mar 25, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants