Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Sort Executor #112

Merged
merged 12 commits into from
Dec 25, 2023
Merged

Optimize Sort Executor #112

merged 12 commits into from
Dec 25, 2023

Conversation

KKould
Copy link
Member

@KKould KKould commented Dec 21, 2023

What problem does this PR solve?

use advance calculation of OrderBy Values to avoid double calculations
Refer to DuckDB using radix sort + memcomparable encode for sorting implementation

ref: https://duckdb.org/2021/08/27/external-sorting.html

fix:

  • nulls first default true

https://zhuanlan.zhihu.com/p/673945166

What is changed and how it works?

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@KKould KKould added the enhancement New feature or request label Dec 21, 2023
@KKould KKould requested a review from guojidan December 21, 2023 14:32
@KKould KKould self-assigned this Dec 21, 2023
@KKould KKould merged commit 9cc8c89 into KipData:main Dec 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant