Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work properly when the source code is using Lf as line endings #2

Closed
Philippe91 opened this issue Jan 24, 2019 · 2 comments
Closed

Comments

@Philippe91
Copy link

In that case, sorting is (slightly) wrong. Converting to Cr/Lf solves the problem, but because of cross-platform development, I use Lf.
Very easy to reproduce: these 3 lines are not sorted.

a
c
b

Another thing: it seems that \Cr\Lf are sometimes added in place of \lf.

@Kir-Antipov
Copy link
Owner

Unfortunately, that's the way it looks...

Didn't think about it during development, so I'm sorry if my LineSorter messed up your files (I know how painful the different line endings in one file/project are for developers)!

It will be fixed in LineSorter 4.0!

@Kir-Antipov
Copy link
Owner

Done!

Successfully added support for the following newline representations:

public enum NewlineType
{
    Undefined,
    LF,
    CRLF,
    CR,
    LFCR,
    // RS // If someone will need it - uncomment!
}

No more broken sortings and newline-type substitutions)


This fix will be available at the Marketplace immediately after the first update (LineSorter 4.0)!

Kir-Antipov added a commit that referenced this issue Feb 13, 2019
- VS 2019 support and some fixes:
    - Different newline representations now available to work with (#2)
    - Custom sorting's windows should now display correctly (#3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants