Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depreciation warnings when using action #39

Closed
ApexModder opened this issue Oct 29, 2022 · 7 comments
Closed

Depreciation warnings when using action #39

ApexModder opened this issue Oct 29, 2022 · 7 comments

Comments

@ApexModder
Copy link

ApexModder commented Oct 29, 2022

The following warning about depreciation is given when using this action.
Solutions are provided via the warnings links

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: Kir-Antipov/mc-publish

The solution from given link

For Actions maintainers: Update your actions to run on Node 16 instead of Node 12 (Actions configuration settings)

@ApexModder ApexModder changed the title Deprecation warnings when using action Depreciation warnings when using action Oct 29, 2022
ApexModder added a commit to ApexStudios-Dev/Commonality that referenced this issue Oct 29, 2022
@Kir-Antipov
Copy link
Owner

Oh no. I have a stale branch that targets Node 16, but there are a lot of problems with dependencies there

@Kir-Antipov
Copy link
Owner

In order to follow this up, I'm working on updating the action to Node16 (alongside with lots of new features) locally. Also, there's plenty of time to get things done until Summer 2023 (GitHub will discontinue support of Node12 actions somewhere around that time), so don't worry.

Node12 may be deprecated, but mc-publish itself won't be until there's at least one fellow developer that needs it :)

@cech12
Copy link

cech12 commented Apr 15, 2023

There are only about 2 months left until summer 2023. Are there any news for this issue? :)

@Kir-Antipov
Copy link
Owner

Yup, will be there on time. Don't worry! The project went through almost a complete rewrite, so it took some time

@osfanbuff63
Copy link
Contributor

On May 18, actions on Node 12 will run Node 16 instead. (source). Seems a little early for "Summer 2023"...

@Kir-Antipov
Copy link
Owner

Thanks a million for alerting me about GitHub Actions moving to Node 16 on May 18th, earlier than the previously announced "Summer 2023". I appreciate the info, as I was still planning based on the original timeline.

Given this change, I'll adjust my plans accordingly. Instead of releasing v4.0, I'll work on a v3.3 release, which won't include support for new platforms and project types but will run on Node 16, allowing users to continue using it without issues. This release will also serve as a starting point for deprecating certain parts of the project I'm not entirely satisfied with.

By introducing the deprecation process in v3.3, users will have ample time to migrate their configurations to the new format. This way, when v4.0 is eventually released, we can move forward without any legacy baggage.

Thanks again for bringing this to my attention!

@Kir-Antipov
Copy link
Owner

v3.3 is now available!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants