Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add supports MSBuild.dll to GUI #479

Merged
merged 7 commits into from
May 1, 2021
Merged

Add supports MSBuild.dll to GUI #479

merged 7 commits into from
May 1, 2021

Conversation

rstm-sf
Copy link
Contributor

@rstm-sf rstm-sf commented Apr 25, 2021

Closes #474

rstm-sf
rstm-sf commented Apr 26, 2021
View reviewed changes
src/StructuredLogViewer.Avalonia/BuildParametersScreen.cs
@@ -64,11 +69,10 @@ private void Copy()
//Clipboard.SetText(commandLine);
}

private ICommand browseForMSBuildCommand;
public ICommand BrowseForMSBuildCommand => browseForMSBuildCommand ?? (browseForMSBuildCommand = new Command(BrowseForMSBuild));
Copy link
Contributor Author

@rstm-sf rstm-sf Apr 26, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can reverts this by implementing AsyncCommand

@rstm-sf rstm-sf marked this pull request as ready for review April 26, 2021 08:02
@rstm-sf
Copy link
Contributor Author

rstm-sf commented Apr 26, 2021

We can use the OmniSharp method to find where the sdk is located

@rstm-sf
Copy link
Contributor Author

rstm-sf commented Apr 26, 2021

Does not change msbuild in case of avalonia

@rstm-sf rstm-sf marked this pull request as draft April 26, 2021 09:11
@KirillOsenkov
Copy link
Owner

Mention me when this is ready for review. Thanks!

@rstm-sf
Copy link
Contributor Author

rstm-sf commented Apr 27, 2021

I think it's enough now :)

@rstm-sf rstm-sf marked this pull request as ready for review April 27, 2021 13:46
@rstm-sf rstm-sf requested a review from KirillOsenkov April 27, 2021 13:49
@KirillOsenkov KirillOsenkov merged commit 2fe5817 into KirillOsenkov:main May 1, 2021
@KirillOsenkov
Copy link
Owner

Thanks!

@rstm-sf rstm-sf deleted the feature/supports_msbuild_dll_to_gui_ branch May 2, 2021 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KirillOsenkov KirillOsenkov Awaiting requested review from KirillOsenkov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add supports MSBuild.dll to GUI
2 participants
@rstm-sf @KirillOsenkov