Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make Struct tuple-like class #343

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Conversation

sangelovic
Copy link
Collaborator

This has Struct implement tuple protocol, making Struct usable virtually anywhere tuple is, i.e. std::get<>(), std::tuple_element, std::tuple_size, and in structured bindings.

@sangelovic sangelovic mentioned this pull request Aug 2, 2023
@sangelovic
Copy link
Collaborator Author

/cc @hellow554

include/sdbus-c++/Types.h Outdated Show resolved Hide resolved
@hellow554
Copy link
Contributor

LGTM.
As said, I try to test it with our current code and report today or tomorrow back if it works. Give me 24 hours ;)

@sangelovic
Copy link
Collaborator Author

@hellow554 OK

@hellow554
Copy link
Contributor

I was able to test your code and it works flawlessly.
I can remove my previous workarounds and everything is fine :)

Thanks a lot for this!

IMHO this is ready to be merged

@sangelovic sangelovic merged commit a29bdc4 into master Aug 3, 2023
5 checks passed
@sangelovic sangelovic deleted the feat/make-struct-tuple-like branch August 3, 2023 10:57
sangelovic added a commit that referenced this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants