Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: moving instead of copying std::string argument #344

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

sangelovic
Copy link
Collaborator

@sangelovic sangelovic commented Aug 3, 2023

This is a proper fix to #323. The argument shall be moved, that's OK, but the problem lies at the source object -- the source shall be a direct object, not a const & to it.

Closes #323

@sangelovic sangelovic merged commit 605fbe4 into master Aug 3, 2023
5 checks passed
@sangelovic sangelovic deleted the fix/moving-argument branch August 3, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant